buildPython*: remove pythonRecompileBytecodeHook as dependency
This hook was added to get reproducible bytecode. Because it was causing issues it was disabled, but still kept as a dependency. Now the main issue with bytecode reproducibility has been resolved by updating pip to 20.2.4, we remove this hook as a dependency. If a package with Python code is not yet reproducible, one could add this hook to `nativeBuildInputs`.
This commit is contained in:
committed by
Frederik Rietdijk
parent
ca6e7454a4
commit
3fceafce1e
@@ -24,8 +24,6 @@ buildPythonPackage rec {
|
||||
# Test failing due to upstream issue (https://bitbucket.org/amentajo/lib3to2/issues/50/testsuite-fails-with-new-python-35)
|
||||
doCheck = false;
|
||||
|
||||
dontUsePythonRecompileBytecode = true;
|
||||
|
||||
meta = {
|
||||
homepage = "https://bitbucket.org/amentajo/lib3to2";
|
||||
description = "Refactors valid 3.x syntax into valid 2.x syntax, if a syntactical conversion is possible";
|
||||
|
||||
@@ -20,9 +20,6 @@ buildPythonPackage rec {
|
||||
# errors with vendored libs
|
||||
doCheck = false;
|
||||
|
||||
# has vendored python2 code
|
||||
dontUsePythonRecompileBytecode = true;
|
||||
|
||||
meta = {
|
||||
description = "Pythonic task execution";
|
||||
license = lib.licenses.bsd2;
|
||||
|
||||
@@ -5,7 +5,7 @@
|
||||
, isPy3k
|
||||
}:
|
||||
|
||||
buildPythonPackage (rec {
|
||||
buildPythonPackage rec {
|
||||
pname = "linecache2";
|
||||
version = "1.0.0";
|
||||
|
||||
@@ -23,8 +23,4 @@ buildPythonPackage (rec {
|
||||
homepage = "https://github.com/testing-cabal/linecache2";
|
||||
license = licenses.psfl;
|
||||
};
|
||||
# TODO: move into main set, this was to avoid a rebuild
|
||||
} // stdenv.lib.optionalAttrs (!isPy3k ) {
|
||||
# syntax error in tests. Tests are likely Python 3 only.
|
||||
dontUsePythonRecompileBytecode = !isPy3k;
|
||||
})
|
||||
}
|
||||
|
||||
@@ -41,8 +41,4 @@ buildPythonPackage (rec {
|
||||
any platform that supports the standard Python pty module.
|
||||
'';
|
||||
};
|
||||
# TODO: move into main set, this was to avoid a rebuild
|
||||
} // lib.optionalAttrs (!isPy3k ) {
|
||||
# syntax error in _async module, likely intended only for Python 3.
|
||||
dontUsePythonRecompileBytecode = !isPy3k;
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user