Get rid of all with { inherit... } and just used let inherit...
The old forms presumably predates, or were made in ignorance of, `let inherit`. This way is better style as the scoping as more lexical, something which Nix can (or might already!) take advantage of.
This commit is contained in:
@@ -7,7 +7,7 @@
|
||||
}:
|
||||
{ platformVersions, abiVersions, useGoogleAPIs, useExtraSupportLibs ? false, useGooglePlayServices ? false }:
|
||||
|
||||
with { inherit (stdenv.lib) makeLibraryPath; };
|
||||
let inherit (stdenv.lib) makeLibraryPath; in
|
||||
|
||||
stdenv.mkDerivation rec {
|
||||
name = "android-sdk-${version}";
|
||||
|
||||
Reference in New Issue
Block a user