Get rid of all with { inherit... } and just used let inherit...
The old forms presumably predates, or were made in ignorance of, `let inherit`. This way is better style as the scoping as more lexical, something which Nix can (or might already!) take advantage of.
This commit is contained in:
@@ -4,7 +4,7 @@
|
||||
|
||||
let basename = "binutils-2.28"; in
|
||||
|
||||
with { inherit (stdenv.lib) optional optionals optionalString; };
|
||||
let inherit (stdenv.lib) optional optionals optionalString; in
|
||||
|
||||
stdenv.mkDerivation rec {
|
||||
name = basename + optionalString (cross != null) "-${cross.config}";
|
||||
|
||||
Reference in New Issue
Block a user