Get rid of all with { inherit... } and just used let inherit...

The old forms presumably predates, or were made in ignorance of, `let inherit`. This way is better style as the scoping as more lexical, something which Nix can (or might already!) take advantage of.
2017-03-30 03:05:05 -04:00
parent da79d1f01f
commit 4c0d7da183
19 changed files with 22 additions and 24 deletions
@@ -12,7 +12,7 @@
 # (--enable-unsupported could be used to force the build)
 assert !cpp || mpi == null;

-with { inherit (stdenv.lib) optional optionals; };
+let inherit (stdenv.lib) optional optionals; in

 stdenv.mkDerivation rec {
  version = "1.8.18";