Merge pull request #105294 from Ericson2314/platform-config-improvements

Platform config improvements

lib/systems/default.nix

@@ -25,7 +25,7 @@ rec {
       system = parse.doubleFromSystem final.parsed;
       config = parse.tripleFromSystem final.parsed;
       # Just a guess, based on `system`
-      platform = platforms.selectBySystem final.system;
+      platform = platforms.select final;
       # Determine whether we are compatible with the provided CPU
       isCompatible = platform: parse.isCompatible final.parsed.cpu platform.parsed.cpu;
       # Derived meta-data

lib/systems/examples.nix

@@ -7,7 +7,7 @@ let
 
   riscv = bits: {
     config = "riscv${bits}-unknown-linux-gnu";
-    platform = platforms.riscv-multiplatform bits;
+    platform = platforms.riscv-multiplatform;
   };
 in
 
@@ -110,13 +110,13 @@ rec {
   riscv64-embedded = {
     config = "riscv64-none-elf";
     libc = "newlib";
-    platform = platforms.riscv-multiplatform "64";
+    platform = platforms.riscv-multiplatform;
   };
 
   riscv32-embedded = {
     config = "riscv32-none-elf";
     libc = "newlib";
-    platform = platforms.riscv-multiplatform "32";
+    platform = platforms.riscv-multiplatform;
   };
 
   mmix = {

lib/systems/platforms.nix

@@ -471,10 +471,9 @@ rec {
   ## Other
   ##
 
-  riscv-multiplatform = bits: {
+  riscv-multiplatform = {
     name = "riscv-multiplatform";
     kernelArch = "riscv";
-    bfdEmulation = "elf${bits}lriscv";
     kernelTarget = "vmlinux";
     kernelAutoModules = true;
     kernelBaseConfig = "defconfig";
@@ -484,17 +483,22 @@ rec {
     '';
   };
 
-  selectBySystem = system: {
+  select = platform:
-      i486-linux = pc32;
+    # x86
-      i586-linux = pc32;
+    /**/ if platform.isx86_32 then pc32
-      i686-linux = pc32;
+    else if platform.isx86_64 then pc64
-      x86_64-linux = pc64;
+
-      armv5tel-linux = sheevaplug;
+    # ARM
-      armv6l-linux = raspberrypi;
+    else if platform.isAarch32 then let
-      armv7a-linux = armv7l-hf-multiplatform;
+      version = platform.parsed.cpu.version or "";
-      armv7l-linux = armv7l-hf-multiplatform;
+      in     if lib.versionOlder version "6" then sheevaplug
-      aarch64-linux = aarch64-multiplatform;
+        else if lib.versionOlder version "7" then raspberrypi
-      mipsel-linux = fuloong2f_n32;
+        else armv7l-hf-multiplatform
-      powerpc64le-linux = powernv;
+    else if platform.isAarch64 then aarch64-multiplatform
-    }.${system} or pcBase;
+
+    else if platform.parsed.cpu == lib.systems.parse.cpuTypes.mipsel then fuloong2f_n32
+
+    else if platform.parsed.cpu == lib.systems.parse.cpuTypes.powerpc64le then powernv
+
+    else pcBase;
 }

pkgs/build-support/bintools-wrapper/default.nix

@@ -167,7 +167,7 @@ stdenv.mkDerivation {
       else if targetPlatform.isWindows then "pe"
       else "elf" + toString targetPlatform.parsed.cpu.bits;
     endianPrefix = if targetPlatform.isBigEndian then "big" else "little";
-    sep = optionalString (!targetPlatform.isMips && !targetPlatform.isPower) "-";
+    sep = optionalString (!targetPlatform.isMips && !targetPlatform.isPower && !targetPlatform.isRiscV) "-";
     arch =
       /**/ if targetPlatform.isAarch64 then endianPrefix + "aarch64"
       else if targetPlatform.isAarch32     then endianPrefix + "arm"
@@ -187,6 +187,7 @@ stdenv.mkDerivation {
       else if targetPlatform.isAlpha then "alpha"
       else if targetPlatform.isVc4 then "vc4"
       else if targetPlatform.isOr1k then "or1k"
+      else if targetPlatform.isRiscV then "lriscv"
       else throw "unknown emulation for platform: ${targetPlatform.config}";
     in if targetPlatform.useLLVM or false then ""
        else targetPlatform.platform.bfdEmulation or (fmt + sep + arch);