From d506e9dd255302d3bacf58c429c48d01cb93cfcf Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Wed, 29 Jan 2020 23:44:10 +0000 Subject: [PATCH 1/4] dino: 2019-10-28 -> 0.1.0 The system libsignal-protocol-c is preferred now, so fetching submodules is no longer required. The other libraries added are ones that the build complained about. I suspect they are optional dependencies. Adding them makes the build quieter, and has basically no impact on runtime closure size, so no harm in making them available to keep the build system happy. --- .../instant-messengers/dino/default.nix | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/pkgs/applications/networking/instant-messengers/dino/default.nix b/pkgs/applications/networking/instant-messengers/dino/default.nix index 5a133dec83d..92a3af4ccb4 100644 --- a/pkgs/applications/networking/instant-messengers/dino/default.nix +++ b/pkgs/applications/networking/instant-messengers/dino/default.nix @@ -2,7 +2,8 @@ , vala, cmake, ninja, wrapGAppsHook, pkgconfig, gettext , gobject-introspection, gnome3, glib, gdk-pixbuf, gtk3, glib-networking , xorg, libXdmcp, libxkbcommon -, libnotify, libsoup, libgee +, libnotify, libsoup, libgee, utillinux, libselinux, libsepol, libpsl, brotli +, libsignal-protocol-c , libgcrypt , epoxy , at-spi2-core @@ -14,15 +15,15 @@ , icu }: -stdenv.mkDerivation { - name = "dino-unstable-2019-10-28"; +stdenv.mkDerivation rec { + pname = "dino"; + version = "0.1.0"; src = fetchFromGitHub { owner = "dino"; repo = "dino"; - rev = "388cc56674487e7b9e339637369fc55f0e271daf"; - sha256 = "1v8rnjbzi8qhwb1fv787byxk8ygfs16z2j64h0s6sd3asr4n0kz1"; - fetchSubmodules = true; + rev = "v${version}"; + sha256 = "1k5cgj5n8s40i71wqdh6m1q0njl45ichfdbbywx9rga5hljz1c54"; }; nativeBuildInputs = [ @@ -51,12 +52,19 @@ stdenv.mkDerivation { pcre xorg.libxcb xorg.libpthreadstubs + xorg.libXtst libXdmcp libxkbcommon epoxy at-spi2-core dbus icu + utillinux + libselinux + libsepol + libpsl + brotli + libsignal-protocol-c ]; enableParallelBuilding = true; From 131ec9d38317f0ba09cda9da1d3c6646bedd485d Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Thu, 30 Jan 2020 00:28:36 +0000 Subject: [PATCH 2/4] dino: drop unnecessary enableParallelBuilding This is the default. --- .../applications/networking/instant-messengers/dino/default.nix | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkgs/applications/networking/instant-messengers/dino/default.nix b/pkgs/applications/networking/instant-messengers/dino/default.nix index 92a3af4ccb4..ad589c8b3f4 100644 --- a/pkgs/applications/networking/instant-messengers/dino/default.nix +++ b/pkgs/applications/networking/instant-messengers/dino/default.nix @@ -67,8 +67,6 @@ stdenv.mkDerivation rec { libsignal-protocol-c ]; - enableParallelBuilding = true; - meta = with stdenv.lib; { description = "Modern Jabber/XMPP Client using GTK/Vala"; homepage = https://github.com/dino/dino; From adb89be62ccfb9f3e8b24e6407d581976b1346da Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Thu, 30 Jan 2020 00:29:11 +0000 Subject: [PATCH 3/4] dino: add myself as a maintainer --- .../applications/networking/instant-messengers/dino/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/instant-messengers/dino/default.nix b/pkgs/applications/networking/instant-messengers/dino/default.nix index ad589c8b3f4..7167ad72558 100644 --- a/pkgs/applications/networking/instant-messengers/dino/default.nix +++ b/pkgs/applications/networking/instant-messengers/dino/default.nix @@ -72,6 +72,6 @@ stdenv.mkDerivation rec { homepage = https://github.com/dino/dino; license = licenses.gpl3; platforms = platforms.linux; - maintainers = [ maintainers.mic92 ]; + maintainers = with maintainers; [ mic92 qyliss ]; }; } From 091b710c3f4f5138afcec281f1a21a203366820c Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Thu, 30 Jan 2020 00:42:24 +0000 Subject: [PATCH 4/4] dino: fix rendering of logo in about window Previously: ** (dino:7442): CRITICAL **: 00:35:22.373: file /build/source/main/src/ui/unified_window.vala: line 86: uncaught error: Unrecognized image file format (gdk-pixbuf-error-quark, 3) (dino:7442): Gtk-WARNING **: 00:35:22.601: Found an icon but could not load it. Most likely gdk-pixbuf does not provide SVG support. --- .../networking/instant-messengers/dino/default.nix | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/networking/instant-messengers/dino/default.nix b/pkgs/applications/networking/instant-messengers/dino/default.nix index 7167ad72558..8928814e967 100644 --- a/pkgs/applications/networking/instant-messengers/dino/default.nix +++ b/pkgs/applications/networking/instant-messengers/dino/default.nix @@ -3,7 +3,7 @@ , gobject-introspection, gnome3, glib, gdk-pixbuf, gtk3, glib-networking , xorg, libXdmcp, libxkbcommon , libnotify, libsoup, libgee, utillinux, libselinux, libsepol, libpsl, brotli -, libsignal-protocol-c +, librsvg, libsignal-protocol-c , libgcrypt , epoxy , at-spi2-core @@ -65,6 +65,7 @@ stdenv.mkDerivation rec { libpsl brotli libsignal-protocol-c + librsvg ]; meta = with stdenv.lib; {