public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tree-wide: replace uses of splitString "." with lib.versions

Browse Source 
Quoting from the splitString docstring:

   NOTE: this function is not performant and should never be used.

This replaces trivial uses of splitString for splitting version
strings with the (potentially builtin) splitVersion.
This commit is contained in:
Joachim Fasting
2019-09-26 17:42:49 +02:00
parent 2d4352b1ae
commit bad07dfac5
27 changed files with 35 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkgs/os-specific/bsd/netbsd/default.nix
+2 -2
View File
@@ -68,9 +68,9 @@ let
} // lib.optionalAttrs stdenv'.isDarwin {
MKRELRO = "no";
} // lib.optionalAttrs (stdenv'.cc.isClang or false) {
HAVE_LLVM = lib.head (lib.splitString "." (lib.getVersion stdenv'.cc.cc));
HAVE_LLVM = lib.versions.major (lib.getVersion stdenv'.cc.cc);
} // lib.optionalAttrs (stdenv'.cc.isGNU or false) {
HAVE_GCC = lib.head (lib.splitString "." (lib.getVersion stdenv'.cc.cc));
HAVE_GCC = lib.versions.major (lib.getVersion stdenv'.cc.cc);
} // lib.optionalAttrs (attrs.headersOnly or false) {
installPhase = "includesPhase";
dontBuild = true;