Merge pull request #20464 from ttuegel/kde-env-no-link

kdeWrapper: reduce closure size

pkgs/development/libraries/kde-frameworks/default.nix

@@ -56,14 +56,8 @@ let
         } // (args.meta or {});
       });
 
-    kdeEnv = import ./kde-env.nix {
-      inherit (pkgs) stdenv lib;
-      inherit (pkgs.xorg) lndir;
-    };
-
     kdeWrapper = import ./kde-wrapper.nix {
       inherit (pkgs) stdenv lib makeWrapper;
-      inherit kdeEnv;
     };
 
     attica = callPackage ./attica.nix {};

pkgs/development/libraries/kde-frameworks/kde-env.nix

@@ -1,31 +0,0 @@
-{ stdenv, lib, lndir }:
-
-drv: pkgs:
-
-stdenv.mkDerivation {
-  name = "kde-env-${drv.name}";
-  nativeBuildInputs = [ lndir ];
-  envPkgs = builtins.map lib.getBin ([drv] ++ pkgs);
-  unpackPhase = "true";
-  configurePhase = "runHook preConfigure; runHook postConfigure";
-  buildPhase = "true";
-  installPhase = ''
-    runHook preInstall
-
-    propagated=""
-    for i in $envPkgs; do
-        findInputs $i propagated propagated-user-env-packages
-    done
-
-    for tgt in bin etc/xdg lib/libexec lib/qt5 share; do
-        mkdir -p "$out/$tgt"
-        for p in $propagated; do
-            if [ -d "$p/$tgt" ]; then
-                lndir -silent "$p/$tgt" "$out/$tgt" >/dev/null 2>&1
-            fi
-        done
-    done
-
-    runHook postInstall
-  '';
-}

pkgs/development/libraries/kde-frameworks/kde-wrapper.nix

@@ -1,17 +1,14 @@
-{ stdenv, lib, makeWrapper, kdeEnv }:
+{ stdenv, lib, makeWrapper }:
 
 drv:
 
 { targets, paths ? [] }:
 
-let
-  env = kdeEnv drv paths;
-in
 stdenv.mkDerivation {
   inherit (drv) name;
 
-  drv = lib.getBin drv;
+  paths = builtins.map lib.getBin ([drv] ++ paths);
-  inherit env targets;
+  inherit drv targets;
   passthru = { unwrapped = drv; };
 
   nativeBuildInputs = [ makeWrapper ];
@@ -21,16 +18,36 @@ stdenv.mkDerivation {
   buildPhase = "true";
 
   installPhase = ''
+    propagated=
+    for p in $drv $paths; do
+        findInputs $p propagated propagated-user-env-packages
+    done
+
+    wrap_PATH="$out/bin"
+    wrap_XDG_DATA_DIRS=
+    wrap_XDG_CONFIG_DIRS=
+    wrap_QML_IMPORT_PATH=
+    wrap_QML2_IMPORT_PATH=
+    wrap_QT_PLUGIN_PATH=
+    for p in $propagated; do
+        addToSearchPath wrap_PATH "$p/bin"
+        addToSearchPath wrap_XDG_DATA_DIRS "$p/share"
+        addToSearchPath wrap_XDG_CONFIG_DIRS "$p/etc/xdg"
+        addToSearchPath wrap_QML_IMPORT_PATH "$p/lib/qt5/imports"
+        addToSearchPath wrap_QML2_IMPORT_PATH "$p/lib/qt5/qml"
+        addToSearchPath wrap_QT_PLUGIN_PATH "$p/lib/qt5/plugins"
+    done
+
     for t in $targets; do
         if [ -a "$drv/$t" ]; then
             makeWrapper "$drv/$t" "$out/$t" \
                 --argv0 '"$0"' \
-                --suffix PATH : "$out/bin:$env/bin" \
+                --suffix PATH : "$wrap_PATH" \
-                --prefix XDG_CONFIG_DIRS : "$env/etc/xdg" \
+                --prefix XDG_CONFIG_DIRS : "$wrap_XDG_CONFIG_DIRS" \
-                --prefix XDG_DATA_DIRS : "$env/share" \
+                --prefix XDG_DATA_DIRS : "$wrap_XDG_DATA_DIRS" \
-                --set QML_IMPORT_PATH "$env/lib/qt5/imports" \
+                --set QML_IMPORT_PATH "$wrap_QML_IMPORT_PATH" \
-                --set QML2_IMPORT_PATH "$env/lib/qt5/qml" \
+                --set QML2_IMPORT_PATH "$wrap_QML2_IMPORT_PATH" \
-                --set QT_PLUGIN_PATH "$env/lib/qt5/plugins"
+                --set QT_PLUGIN_PATH "$wrap_QT_PLUGIN_PATH"
         else
             echo "no such file or directory: $drv/$t"
             exit 1