public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Excise use of importJSON

Browse Source 
Putting information in external JSON files is IMHO not an improvement
over the idiomatic style of Nix expressions. The use of JSON doesn't
add anything over Nix expressions (in fact it removes expressive
power). And scattering package info over lots of little files makes
packages less readable over having the info in one file.
This commit is contained in:
Eelco Dolstra
2017-01-30 11:44:08 +01:00
parent 2dc87881b0
commit c20cc6d0b3
10 changed files with 30 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkgs/os-specific/linux/tp_smapi/default.nix
+8 -5
View File
@@ -1,12 +1,15 @@
{ stdenv, fetchurl, kernel, writeScript, coreutils, gnugrep, jq, curl
}:
let
data = stdenv.lib.importJSON ./update.json;
in stdenv.mkDerivation rec {
name = "tp_smapi-${data.version}-${kernel.version}";
stdenv.mkDerivation rec {
name = "tp_smapi-${version}-${kernel.version}";
src = fetchurl { inherit (data) url sha256; };
version = "0.42";
src = fetchurl {
url = "https://github.com/evgeni/tp_smapi/archive/tp-smapi/${version}.tar.gz";
sha256 = "cd28bf6ee21b2c27b88d947cb0bfcb19648c7daa5d350115403dbcad05849381";
};
hardeningDisable = [ "pic" ];