Addressing PR feedback
This commit is contained in:
@@ -11,13 +11,6 @@ in
|
||||
|
||||
config = mkIf cfg.enable {
|
||||
environment.systemPackages = [ pkgs.kbdlight ];
|
||||
|
||||
security.permissionsWrappers.setuid =
|
||||
[ { program = "kbdlight";
|
||||
source = "${pkgs.kbdlight.out}/bin/kbdlight";
|
||||
owner = "root";
|
||||
group = "root";
|
||||
setuid = true;
|
||||
}];
|
||||
security.setuidPrograms = [ "kbdlight" ];
|
||||
};
|
||||
}
|
||||
|
||||
@@ -21,13 +21,6 @@ in
|
||||
|
||||
config = mkIf cfg.enable {
|
||||
environment.systemPackages = [ pkgs.light ];
|
||||
|
||||
security.permissionsWrappers.setuid =
|
||||
[ { program = "light";
|
||||
source = "${pkgs.light.out}/bin/light";
|
||||
owner = "root";
|
||||
group = "root";
|
||||
setuid = true;
|
||||
}];
|
||||
security.setuidPrograms = [ "light" ];
|
||||
};
|
||||
}
|
||||
|
||||
@@ -101,49 +101,9 @@ in
|
||||
chpasswd = { rootOK = true; };
|
||||
};
|
||||
|
||||
|
||||
security.permissionsWrappers.setuid =
|
||||
[
|
||||
{ program = "su";
|
||||
source = "${pkgs.shadow.su}/bin/su";
|
||||
owner = "root";
|
||||
group = "root";
|
||||
setuid = true;
|
||||
}
|
||||
|
||||
{ program = "chfn";
|
||||
source = "${pkgs.shadow.out}/bin/chfn";
|
||||
owner = "root";
|
||||
group = "root";
|
||||
setuid = true;
|
||||
}
|
||||
] ++
|
||||
(lib.optionals config.users.mutableUsers
|
||||
map (x: x // { owner = "root";
|
||||
group = "root";
|
||||
setuid = true;
|
||||
})
|
||||
[
|
||||
{ program = "passwd";
|
||||
source = "${pkgs.shadow.out}/bin/passwd";
|
||||
}
|
||||
|
||||
{ program = "sg";
|
||||
source = "${pkgs.shadow.out}/bin/sg";
|
||||
}
|
||||
|
||||
{ program = "newgrp";
|
||||
source = "${pkgs.shadow.out}/bin/newgrp";
|
||||
}
|
||||
|
||||
{ program = "newuidmap";
|
||||
source = "${pkgs.shadow.out}/bin/newuidmap";
|
||||
}
|
||||
|
||||
{ program = "newgidmap";
|
||||
source = "${pkgs.shadow.out}/bin/newgidmap";
|
||||
}
|
||||
]
|
||||
);
|
||||
security.setuidPrograms = [
|
||||
"su" "chfn" "newuidmap" "newgidmap"
|
||||
] ++ lib.optionals config.users.mutableUsers
|
||||
[ "passwd" "sg" "newgrp" ];
|
||||
};
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user